Repository navigation
Fix createSelect().enable() resetting the selected option - #9399
Open
pedrohpalma wants to merge 1 commit into
Open
pedrohpalma wants to merge 1 commit into
pedrohpalma wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9388
Changes:
src/dom/dom.js: removed theselected = falseassignments from both branches ofenable()(enable()andenable(option)), so it now only changes thedisabledstate.disable()is unchanged.src/dom/dom.js: added one sentence to thecreateSelect()reference saying that enabling a dropdown or option doesn't change which option is selected.test/unit/dom/dom.js: added two tests in thecreateSelectsuite. They check that the selected option is preserved afterdisable()+enable()and afterenable(option). They fail without the fix.Screenshots of the change:
PR Checklist
npm run lintpasses